Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New Feature: wysiwyg design time editing - add and remove spacer widgets #1482

Merged
merged 1 commit into from
Nov 19, 2024

Conversation

Steve-Mcl
Copy link
Contributor

closes #1479

Description

New feature - ability to add and remove widgets in the dashboard at edit time.

Refactors a lot of the non-store stuff into a new store named wysiwyg - this is primarily to take advantage of actions and preparation for #1481

This is an extension of (and thus) merges into #1468

Demo

chrome_txdDw0dM7w

Related Issue(s)

#1479

Checklist

  • I have read the contribution guidelines
  • Suitable unit/system level tests have been added and they pass
  • Documentation has been updated
    • Upgrade instructions
    • Configuration details
    • Concepts
  • Changes flowforge.yml?
    • Issue/PR raised on FlowFuse/helm to update ConfigMap Template
    • Issue/PR raised on FlowFuse/CloudProject to update values for Staging/Production

Labels

  • Includes a DB migration? -> add the area:migration label

closes WYSIWYG: Ability to add and remove spacers #1479
@Steve-Mcl Steve-Mcl requested a review from joepavitt November 19, 2024 18:18
@Steve-Mcl Steve-Mcl linked an issue Nov 19, 2024 that may be closed by this pull request
@Steve-Mcl Steve-Mcl merged commit 105b2c4 into widget-wysiwyg Nov 19, 2024
1 of 2 checks passed
@Steve-Mcl Steve-Mcl deleted the wysiwyg-add-rem-spacer branch November 19, 2024 20:54
@NZHYDROGEN
Copy link

There is an issue with the layout editor in 1.21.0, its just loading a blank page

@NZHYDROGEN
Copy link

There is an issue with the layout editor in 1.21.0, its just loading a blank page

when using console it is showing this error: Failed to load module script: Expected a JavaScript module script but the server responded with a MIME type of "text/html". Strict MIME type checking is enforced for module scripts per HTML spec.

@joepavitt
Copy link
Collaborator

@NZHYDROGEN do you have anything different about your Node-RED setup? Proxy? How is it hosted?

@colinl
Copy link
Contributor

colinl commented Jan 1, 2025

@NZHYDROGEN what browser and version are you using? Can you try a different browser?
Try restarting node-red and clear the browser cache (via the browser menus not hot key).

@NZHYDROGEN
Copy link

NZHYDROGEN commented Jan 1, 2025 via email

@NZHYDROGEN
Copy link

for example this works:
Screenshot 2025-01-02 103121

but if i have a page like this it wont load the editor:
Screenshot 2025-01-02 103227

@NZHYDROGEN
Copy link

I have tried clearing the browser, rebooting, other browsers and the fault can be replicated every time.

@NZHYDROGEN
Copy link

my feeling is there is a conflict with the editor when the page has a Ui-Table?

@bartbutenaers
Copy link
Contributor

@NZHYDROGEN,
I had exactly the same error recently in my custom ui-web-push node. But can't remember it exactly, because I had multiple related problems at that moment.

Could you please open the Developer Tools of your browser, and have a look in the Network tabsheet for any errors. Might be that you then need to reload your page.

@NZHYDROGEN
Copy link

Yea, I have tried that i can replicate the issue on any page where there is a Ui-Table present

@NZHYDROGEN
Copy link

its gets this error in console with any page using a Ui-Table: Failed to load module script: Expected a JavaScript module script but the server responded with a MIME type of "text/html". Strict MIME type checking is enforced for module scripts per HTML spec.

@bartbutenaers
Copy link
Contributor

And do you see any errors in the Network tabsheet?

@NZHYDROGEN
Copy link

just this one:
Screenshot 2025-01-02 110632

@bartbutenaers
Copy link
Contributor

Thanks! That makes no sense to me. I had expected to see an error here. But not sure. Seems you have no filter applied and show "All" requests. So that is good.

You might keep this tabsheet open and refresh your dashboard browser page, to see whether errors popup.

I am off to sleep. See you tomorrow...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

WYSIWYG: Ability to add and remove spacers
5 participants